Convert rust example to node #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minimal conversion from previous operator api to node api. Ref dora-rs#474
Previously, this dataflow relied on an incorrect shared library.
|
NOTE: I do not think that last commit fixed the CI failure for 5f87384. I suspected the failure was spurious, so I added the last commit to trigger a second run. |
phil-opp
approved these changes
May 1, 2024
There was a problem hiding this comment.
Looks good, thanks!
NOTE: I do not think that last commit fixed the CI failure for 5f87384.
I suspected the failure was spurious, so I added the last commit to trigger a second run.
Yes, that failure seems spurious. I restarted the failed job and it worked on the second try.
the Q was answered in review. stopping is unnecessary because the `event_stream` wills top shortly Co-authored-by: Philipp Oppermann <dev@phil-opp.com>
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #474
1st commit is a minimalist conversion, tried to keep the behavior the same.
2nd commit removes some extra dependencies.
Note
The end behavior does appear different. On main, I will get ~10 to ~30 messages about dropped inputs, and I will only get
100 - num_droppedforoperator received random valueWith this conversion to the node api, i get no messages about dropped inputs and 100
operated received random value.Ran with: