-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add-armv7-musleabihf-prebuilt-release #578
Conversation
The "hot fix" in the PR title seems to indicate that this fixes some critical issue? Could you clarify what this issue is? Or is this just an improvement/simplification? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR seems to be doing multiple things at once, including adding support for some targets, removing support for other targets, hot fixing some (?) issues, updating various actions, refactoring the whole release script, and adding some install.sh
(that is not used anywhere?). This makes this quite difficult to review unfortunately.
Yes, so for context: on 0.3.5 release, something very weird happened and I can't make the CI compile x86 anymore: https://github.com/dora-rs/dora/actions/runs/9693826084 where as it working just 5min prior on 0.3.5-rc0: https://github.com/dora-rs/dora/actions/runs/9683533684 This made it that pip did not receive 0.3.5 and people could not update their python version. Thus the hot-fix in the title. |
I think we should test all the platforms that we want to support as part of our |
We release for these targets, so we should check them during CI runs too.
Check build for cross-compiled targets on CI
Test pip release creation as part of normal CI
Thanks! |
This PR simplify our github release and explicit our target within our release naming for clarity.