Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-armv7-musleabihf-prebuilt-release #578

Merged
merged 17 commits into from
Jul 21, 2024
Merged

Add-armv7-musleabihf-prebuilt-release #578

merged 17 commits into from
Jul 21, 2024

Conversation

haixuanTao
Copy link
Collaborator

This PR simplify our github release and explicit our target within our release naming for clarity.

@haixuanTao haixuanTao enabled auto-merge July 9, 2024 04:01
@haixuanTao haixuanTao disabled auto-merge July 9, 2024 05:28
@phil-opp
Copy link
Collaborator

The "hot fix" in the PR title seems to indicate that this fixes some critical issue? Could you clarify what this issue is? Or is this just an improvement/simplification?

Copy link
Collaborator

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR seems to be doing multiple things at once, including adding support for some targets, removing support for other targets, hot fixing some (?) issues, updating various actions, refactoring the whole release script, and adding some install.sh (that is not used anywhere?). This makes this quite difficult to review unfortunately.

.github/workflows/pip-release.yml Outdated Show resolved Hide resolved
.github/workflows/pip-release.yml Show resolved Hide resolved
.github/install.sh Outdated Show resolved Hide resolved
@haixuanTao
Copy link
Collaborator Author

Yes, so for context: on 0.3.5 release, something very weird happened and I can't make the CI compile x86 anymore: https://github.com/dora-rs/dora/actions/runs/9693826084 where as it working just 5min prior on 0.3.5-rc0: https://github.com/dora-rs/dora/actions/runs/9683533684

This made it that pip did not receive 0.3.5 and people could not update their python version.

Thus the hot-fix in the title.

@haixuanTao haixuanTao changed the title Hot fix pip release Add-armv7-within-prebuilt-release Jul 15, 2024
@haixuanTao haixuanTao changed the title Add-armv7-within-prebuilt-release Add-armv7-prebuilt-release Jul 15, 2024
@haixuanTao haixuanTao changed the title Add-armv7-prebuilt-release Add-armv7-musleabihf-prebuilt-release Jul 15, 2024
@phil-opp
Copy link
Collaborator

I think we should test all the platforms that we want to support as part of our ci.yml. This way, we see potential errors directly instead of discovering them when we do a release.

We release for these targets, so we should check them during CI runs too.
@phil-opp
Copy link
Collaborator

I think we should test all the platforms that we want to support as part of our ci.yml. This way, we see potential errors directly instead of discovering them when we do a release.

I opened #596 and #597 for that.

@haixuanTao haixuanTao mentioned this pull request Jul 21, 2024
Test pip release creation as part of normal CI
@phil-opp phil-opp merged commit 542afe2 into main Jul 21, 2024
38 checks passed
@phil-opp phil-opp deleted the hot-fix-pip-release branch July 21, 2024 14:01
@phil-opp
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants