Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watchAll ignores sinceResourceVersion #150

Closed
alanbur opened this issue May 17, 2018 · 1 comment
Closed

watchAll ignores sinceResourceVersion #150

alanbur opened this issue May 17, 2018 · 1 comment

Comments

@alanbur
Copy link

alanbur commented May 17, 2018

watchAll takes an Option parameter sinceResourceVersion which allows specification of the starting point from which events are to be delivered. watchAll in turn calls eventsOnKind which constructs a maybeResourceVersionQuery parameter with which to specify the revision, but it isn't passed into the subsequent context.buildRequest call, so any specified resource version is ignored.

Looking at the similar events method immediately above suggests the call to context.buildRequest in eventsOnKind should be:

val request = context.buildRequest(HttpMethods.GET, rd, None, query = maybeResourceVersionQuery, watch=true)
@doriordan
Copy link
Owner

Thanks -definitely a bug, fixed by PR #153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants