Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeleteOptions: support propagationPolicy and preconditions #44

Closed
doriordan opened this issue Apr 9, 2017 · 0 comments · Fixed by #104
Closed

DeleteOptions: support propagationPolicy and preconditions #44

doriordan opened this issue Apr 9, 2017 · 0 comments · Fixed by #104
Labels
feature request

Comments

@doriordan
Copy link
Owner

Currently the DeleteOptions implementation doesn't support setting propagationPolicy or preconditions, which were added since it was implemented. These settings can be useful (especially propagationPolicy) so should be supported.

(It also doesn't support orphanDependents but that is deprecated in favour of propagationPolicy so no point in implementing support for it now)
@doriordan doriordan mentioned this issue Jan 13, 2018
Merged
doriordan added a commit that referenced this issue Jan 13, 2018
@doriordan
Addresses several issues (#104)
1a79812 
- Enhances StatefulSet to resolve #103
- Adds method deleteWithOptions to resolve #44
- Fixes #102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Addresses several issues doriordan/skuber
1 participant
@doriordan