Add toleration to the API #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/ Signed-off-by: Adam Oliver Zsigmond <azsigmond@hiya.com>
doriordan
reviewed
Mar 10, 2018
| @@ -0,0 +1,31 @@ | |||
| package skuber | |||
There was a problem hiding this comment.
It is a matter of style really but as tolerations are tied to pods (and used in pod specs only) - I would prefer to define the Toleration type in the Pod scope (i.e. within the Pod companion object) similar to e.g. Pod.Affinity, Pod.Condition.
Does this seem reasonable?
There was a problem hiding this comment.
I guess it is, just Pod is kinda big already.
Signed-off-by: Adam Oliver Zsigmond <azsigmond@hiya.com>
|
Is there anything blocking this now? |
|
Nothing blocking this @zsedem I am just catching up with it now, looks good thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/
Signed-off-by: Adam Oliver Zsigmond azsigmond@hiya.com