-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Are filters AND
ed?
#45
Comments
Yeah I got notification that @getsentry forked the repo. Then I got an idea I could use it as a "real world" usage example in successful project :) Your findings are correct. Filter evaluates to true if any of the path patterns matches any file - so it's
Unfortunately I found out minimatch library is not handling this correctly.
|
micromatch claims to support full Bash 4.3 spec and it actually passes all the tests. For example this fixes processing of '!(**/*.tsx|**/*.less)' pattern - needed by #45
* Use micromatch instead of minimatch micromatch claims to support full Bash 4.3 spec and it actually passes all the tests. For example this fixes processing of '!(**/*.tsx|**/*.less)' pattern - needed by #45 * Update CHANGELOG.md
Hey, great work on this, I see you've discovered our usage of it at Sentry. We're trying to use a few negation filters together, as an example
However, this doesn't work as I had expected - it seems to be
OR
ing each filter so if I had a commit where atsx
file changed,backend
would still match due to the second filter. Is this expected? Am I writing the filters incorrectly?The text was updated successfully, but these errors were encountered: