Merge pull request #214 from trond-snekvik/fail-on-error

Only report failure if fail-on-error is set
dorny · Nov 30, 2022 · 75b0cad · 75b0cad
2 parents 8bf0c7d + 0042016
commit 75b0cad
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/package.json b/package.json
@@ -9,7 +9,7 @@
     "format": "prettier --write **/*.ts",
     "format-check": "prettier --check **/*.ts",
     "lint": "eslint src/**/*.ts",
-    "package": "ncc build --license licenses.txt && eolConverter lf dist/*",
+    "package": "ncc build --license licenses.txt && eolConverter lf 'dist/*'",
     "test": "jest --ci --reporters=default --reporters=jest-junit",
     "all": "npm run build && npm run format && npm run lint && npm run package && npm test",
     "dart-fixture": "cd \"reports/dart\" && dart test --file-reporter=\"json:../../__tests__/fixtures/dart-json.json\"",

diff --git a/src/main.ts b/src/main.ts
@@ -174,7 +174,7 @@ class TestReporter {
     core.info('Creating annotations')
     const annotations = getAnnotations(results, this.maxAnnotations)
 
-    const isFailed = results.some(tr => tr.result === 'failed')
+    const isFailed = this.failOnError && results.some(tr => tr.result === 'failed')
     const conclusion = isFailed ? 'failure' : 'success'
     const icon = isFailed ? Icon.fail : Icon.success