Merge pull request #332 from jozefizso/dev/node18_runtime

Use NodeJS 18 LTS as default runtime
dorny · Dec 13, 2023 · 84909f3 · 84909f3
2 parents 601ab2b + e091fad
commit 84909f3
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 10 deletions.
diff --git a/.github/workflows/check-dist.yml b/.github/workflows/check-dist.yml
@@ -23,10 +23,10 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
-      - name: Set Node.js 16.x
-        uses: actions/setup-node@v3
+      - name: Set Node.js
+        uses: actions/setup-node@v4
         with:
-          node-version: 16.x
+          node-version-file: '.nvmrc'
 
       - name: Install dependencies
         run: npm ci

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -14,7 +14,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-      - run: node --version
+      - uses: actions/setup-node@v4
+        with:
+          node-version-file: '.nvmrc'
       - run: npm ci
       - run: npm run build
       - run: npm run format-check

diff --git a/.nvmrc b/.nvmrc
@@ -1 +1 @@
-v18.7.0
+v18.19.0
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -47,7 +47,7 @@
     "@types/adm-zip": "^0.5.0",
     "@types/github-slugger": "^1.3.0",
     "@types/jest": "^28.1.7",
-    "@types/node": "^18.7.7",
+    "@types/node": "^18.19.3",
     "@types/picomatch": "^2.2.1",
     "@types/xml2js": "^0.4.8",
     "@typescript-eslint/eslint-plugin": "^5.33.1",