Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fail-on-error: 'false' still fails on error #161

Closed
kpturner opened this issue Mar 4, 2022 · 0 comments · Fixed by #214 · May be fixed by #220
Closed

fail-on-error: 'false' still fails on error #161

kpturner opened this issue Mar 4, 2022 · 0 comments · Fixed by #214 · May be fixed by #220

Comments

@kpturner
Copy link

kpturner commented Mar 4, 2022

image
trond-snekvik added a commit to trond-snekvik/test-reporter that referenced this issue Nov 30, 2022
@trond-snekvik
Only report failure if fail-on-error is set
e7733f4 
The flag is checked when exiting early, but the report update at the end ignores it, causing the test run to be reported as a failure.

Fixes dorny#161.

Signed-off-by: Trond Einar Snekvik <Trond.Einar.Snekvik@nordicsemi.no>
@trond-snekvik trond-snekvik mentioned this issue Nov 30, 2022
Merged
@Wilsontomass Wilsontomass mentioned this issue Dec 1, 2022
Open
Wilsontomass added a commit to Wilsontomass/test-reporter that referenced this issue Dec 19, 2022
@Wilsontomass
Don't fail empty results if failOnError is False
afd11d4 
This also changes how the check is created, failing the check on failing tests.
This resolves dorny#217  and also resolves dorny#161.
@Wilsontomass Wilsontomass mentioned this issue Dec 19, 2022
Open
@Wilsontomass Wilsontomass mentioned this issue May 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@kpturner