-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding coverage reports (e.g. for lcov format) #117
Comments
Hello, I was thinking about this some time ago but came to the conclusion it has low priority because there are other projects doing it. |
The one feature that differentiates your work from all other projects I could find is that the results will be displayed as a Github Action Check Run (and not e.g. as a comment on the PR or on an external site like codecov). This approach is very concise (not cluttering the PR) and only relatable to one specific run. So combining test results and their coverage in a single view would be great. |
Thanks, that makes sense. For the beginning, I would like to support Existing actions, including the one you linked, just wrap other tools that convert coverage files into HTML. Here I would have to do parsing and visualization from scratch. It will need some time. I will put this on my to-do list but unfortunately, it won't be done anytime soon. I just got a new job and my availability for this project is quite limited now. In the next months, I will focus rather on bug fixes and simpler improvements than a completely new feature. |
Perfect! Personally, I only care about Additionally, I totally understand that this feature is not your highest priority - but with that in mind, I'm wondering why wrapping other tools is not an option in this case? I thought, content needs to be delivered as markdown, so basically creating HTML and converting that to markdown should be fine as well, shouldn't it? |
Hi Dorny, I have the same request. If you could add Jacoco and Corbetura icov support by parsing XML and displaying in table similar to test results display. I understand you are busy with new job. Just when ever you can get to it. Thank you for this awesome github action you have created. |
Hi guys, I'm looking to make this work on my fork. PR #259 I will be in touch with you, |
Hi guys, I worked a little bit in a branch for adding I use it in another projet to me : https://github.com/j-catania/emusk/actions/runs/7390220838/job/20104669346 |
Could you please have a look at the PR and tell me what you think please ? |
@j-catania the PR looks very concise, but I agree with @dorny 's comment:
|
Hey there,
first, thanks for your work, this github action is awesome!
Nevertheless, it would be even more awesome, if one could see code coverage information next to the test reports. Maybe an additional property
coverage-files
could be added (see this one as an example), which takes lcov files as an input and displays the information if the property is set? What are your thoughts about that?Thanks in advance.
Best regards,
Alex
The text was updated successfully, but these errors were encountered: