-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LCOV Support #352
base: main
Are you sure you want to change the base?
Add LCOV Support #352
Conversation
Bumps [xml2js](https://github.com/Leonidas-from-XIV/node-xml2js) from 0.4.23 to 0.5.0. - [Commits](https://github.com/Leonidas-from-XIV/node-xml2js/commits/0.5.0) --- updated-dependencies: - dependency-name: xml2js dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
….5.0 Bump xml2js from 0.4.23 to 0.5.0
# Conflicts: # __tests__/lcov.test.ts # action.yml # package-lock.json # package.json # src/main.ts
Adding LCOV Support
# Conflicts: # dist/index.js # src/main.ts
I don't known what to do with the 3 tests. What do you think about this POC ? |
So the parser takes information about the coverage of each file and represents the results as 3 tests - for lines, functions, and branches. Do I understand it correctly? IMHO, this feels quite hacky. I can imagine using such an approach for my private work, but I don't think it's a good idea to have this in public action. It might confuse users. Another issue is the hardcoded 80% threshold, this would have to be configurable in the final implementation. I think if lcov should be supported by test-reporter, it would require a specialized implementation for producing output in a different layout and also adding input variables for a passing threshold. The output should probably not only show if it passed but also an actual number. |
No description provided.