-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add gh action output for url
and url_html
#198
Conversation
Add go-unit test
Avoid NaN in totalTime
@peterwhitesell Thanks for your contribution. |
@dorny merged in main and resolved conflicts in |
core.setOutput('url', resp.data.url) | ||
core.setOutput('url_html', resp.data.html_url) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peterwhitesell I've just noticed this is executed in a loop. Multiple check runs might be created if the input path has a pattern matching more files. In that case, the url
variable would be set to the last one. What's your use case? We could leave it as is or output JSON encoded array instead. Not sure what's a better approach.
@@ -211,6 +214,8 @@ class TestReporter { | |||
return new JestJunitParser(options) | |||
case 'mocha-json': | |||
return new MochaJsonParser(options) | |||
case 'go-junit': | |||
return new GoJunitParser(options) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have go-junit support documented in the README and action.yml
Hi @dorny and @peterwhitesell
|
@peterwhitesell and @dorny seems this PR is not moving forward. |
I am the original developer of this feature and i decide to create another PR |
#242 Merged. |
Changes
url
andurl_html
so they can be referenced by other actions in a workflow