🪲 fixed "Error: TypeError: Cannot read properties of undefined (readi… #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng 'split')" if failure element is empty
bartam1
approved these changes
Jul 25, 2023
|
@uebelack, could you please fix all CI and I will merge it. Thanks for your help |
|
The bug with calling We will add the new unit test from this PR, but the change in the |
|
And the new |
jozefizso
requested changes
Dec 31, 2023
| it('report from jest in junit format', async () => { | ||
| const fixturePath = path.join(__dirname, 'fixtures', 'external', 'java', 'test-report-jest.xml') | ||
| const trackedFilesPath = path.join(__dirname, 'fixtures', 'external', 'java', 'files.txt') | ||
| const outputPath = path.join(__dirname, '__outputs__', 'pulsar-test-results.md') |
There was a problem hiding this comment.
The pulsar-test-results.md output file is used by another test.
| @@ -19,6 +19,6 @@ export function parseIsoDate(str: string): Date { | |||
| } | |||
|
|
|||
| export function getFirstNonEmptyLine(stackTrace: string): string | undefined { | |||
| const lines = stackTrace?.split(/\r?\n/g) | |||
| return lines?.find(str => !/^\s*$/.test(str)) | |||
| const lines = stackTrace ? stackTrace.split(/\r?\n/g) : [] | |||
There was a problem hiding this comment.
This change is no longer necessary - see #258
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ng 'split')" if failure element is empty
closes #159
closes #241