-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update checkout and upload-artifact actions versions #419
Update checkout and upload-artifact actions versions #419
Conversation
It is not apparent from the build checks, but these changes are failing the workflow: https://github.com/dorny/test-reporter/actions/runs/8596798196 |
@jozefizso interesting, I do not think it is related to my changeset actually. Am I the first outside contributor who had auth problems for the download artifact action in this pipeline? Edit: looking at the history it seems that I am the only one with the problem. I will create a minimal documentation change instead to see if the problem is with my changeset or some sort of weird auth issue. |
#420 created this and just realized the CI action ignores the |
Related to: I confirm this problem. I bet that if you revert these changes then things will work again. - - uses: actions/upload-artifact@v3
+ - uses: actions/upload-artifact@v4 |
Related: #343 TLDR: artifacts@v4 is NOT compatible with artifacts@v3 and may lead to auth issues, among others. See https://github.blog/changelog/2023-12-14-github-actions-artifacts-v4-is-now-generally-available/ |
@jozefizso I added a hail-mary fix attempt for the solution after diving into @abelbraaksma has provided and reading this Reddit comment. IDK if this is the correct direction but I think we might as well give it a try. TLDR: providing |
Would it be possible for us to give the proposed solution a try? |
f47cc9c
to
4a41820
Compare
No description provided.