Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small mistakes in sil example #194

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Fix small mistakes in sil example #194

merged 2 commits into from
Mar 25, 2024

Conversation

Impelon
Copy link
Contributor

@Impelon Impelon commented Mar 23, 2024

Seems like there are a few small mistakes in the sil example.
Consider doing a sqash-merge of these small commits :)

@Impelon Impelon changed the title Fix power_meters in sil example Fix small mistakes in sil example Mar 24, 2024
@Impelon
Copy link
Contributor Author

Impelon commented Mar 24, 2024

The test to see if examples/sil_example.ipynb runs is currently not included in the Build workflow. Probably because it would take 24 * 3600 seconds to run it.

If one applies these fixes and reduces the time given for the simulation, the test works fine though. One could consider replacing the until parameter in examples/sil_example.ipynb during the execution of the workflow with sed or similar...
Might be a bit overkill though, especially because using sed will only work as long as the example does not significantly change.

Copy link
Contributor

@marvin-steinke marvin-steinke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes the SiL example is kind of a WIP right now. Thanks for the fixes :)

@birnbaum birnbaum merged commit b214c7c into dos-group:main Mar 25, 2024
2 checks passed
@birnbaum
Copy link
Collaborator

thanks a lot!

@Impelon Impelon deleted the patch-1 branch March 26, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants