Start Broker's receiver in API process
#207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impelon
changed the title
Broker's receiver in correct processBroker's receiver in API process
marvin-steinke
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The receive-Thread must be started by the same
multiprocessing.Processas the process the API is running in. Otherwise any data from the broker will be unavailable to the API.Starting the recieve-Thread of the broker directly on instantiation is an oversight, as it needs to be started later manually by the API process.
One could also add a
startfunction to the Broker if one wanted to make it prettier, but this is the minimum needed to actually make the new SIL interface work.