Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage improvements #231

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Storage improvements #231

merged 4 commits into from
Aug 30, 2024

Conversation

kilianp14
Copy link
Contributor

@kilianp14 kilianp14 commented Jul 30, 2024 •
edited
Loading

  • Fixes in the SimpleBattery regarding floating point inaccuracies when computing e-delta + a better handling of the minimum SoC
  • Fixed bug that crashed simulations when no Controller was present
  • Added C-L-C model to vessim storage + tests
  • Added example on how to use PyBaMM battery models with Vessim

marvin-steinke
marvin-steinke approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@marvin-steinke marvin-steinke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@marvin-steinke marvin-steinke merged commit 63fc53b into main Aug 30, 2024
4 checks passed
@marvin-steinke marvin-steinke deleted the storage_improvements branch August 30, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvin-steinke marvin-steinke marvin-steinke approved these changes

@birnbaum birnbaum birnbaum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kilianp14 @birnbaum @marvin-steinke