-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(edit-content): implement relationship field data table with mock data #30825
feat(edit-content): implement relationship field data table with mock data #30825
Conversation
…ure-for-edit-contentlet
…ure-for-edit-contentlet
…ure-for-edit-contentlet
…ure-for-edit-contentlet
…ure-for-edit-contentlet
…ure-for-edit-contentlet
|
…ure-for-edit-contentlet
…ure-for-edit-contentlet
…ure-for-edit-contentlet
…-data' of github.com:dotCMS/core into 30523-implement-relationship-field-data-table-with-mock-data
…ring and deletion functionality
…tion and improved hint display
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 15 changed files in this pull request and generated no suggestions.
Files not reviewed (10)
- core-web/libs/dotcms-scss/shared/_colors.scss: Language not supported
- core-web/libs/edit-content/src/lib/components/dot-edit-content-field/dot-edit-content-field.component.html: Language not supported
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/dot-select-existing-content/components/pagination/pagination.component.html: Language not supported
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/dot-select-existing-content/dot-select-existing-content.component.html: Language not supported
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/pagination/pagination.component.html: Language not supported
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/dot-edit-content-relationship-field.component.html: Language not supported
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/dot-edit-content-relationship-field.component.scss: Language not supported
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/dot-edit-content-relationship-field.component.ts: Evaluated as low risk
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/dot-select-existing-content/dot-select-existing-content.component.ts: Evaluated as low risk
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/pagination/pagination.component.ts: Evaluated as low risk
Comments skipped due to low confidence (1)
core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/services/relationship-field.service.ts:73
- [nitpick] The hardcoded language values should be made configurable or documented clearly to avoid confusion.
language: faker.helpers.arrayElement(['English (en-us)', 'Spanish (es-es)', 'French (fr-fr)']),
2024-12-05.16-56-26.mp4Resposive 2024-12-05.17-01-10.mp4 |
…mprove UI text for selected items
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 15 changed files in this pull request and generated no suggestions.
Files not reviewed (10)
- core-web/libs/dotcms-scss/shared/_colors.scss: Language not supported
- core-web/libs/edit-content/src/lib/components/dot-edit-content-field/dot-edit-content-field.component.html: Language not supported
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/dot-select-existing-content/components/pagination/pagination.component.html: Language not supported
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/dot-select-existing-content/dot-select-existing-content.component.html: Language not supported
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/pagination/pagination.component.html: Language not supported
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/dot-edit-content-relationship-field.component.html: Language not supported
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/dot-edit-content-relationship-field.component.scss: Language not supported
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/dot-edit-content-relationship-field.component.ts: Evaluated as low risk
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/dot-select-existing-content/dot-select-existing-content.component.ts: Evaluated as low risk
- core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/components/pagination/pagination.component.ts: Evaluated as low risk
Comments skipped due to low confidence (1)
core-web/libs/edit-content/src/lib/fields/dot-edit-content-relationship-field/services/relationship-field.service.ts:73
- The 'language' property should be consistent with the application's supported languages. Ensure that the values are not randomly generated.
language: faker.helpers.arrayElement(['English (en-us)', 'Spanish (es-es)', 'French (fr-fr)']),
…-data' of github.com:dotCMS/core into 30523-implement-relationship-field-data-table-with-mock-data
…ck-data' and '30523-implement-relationship-field-data-table-with-mock-data' of github.com:dotCMS/core into 30523-implement-relationship-field-data-table-with-mock-data
Parent Issue
#30523
Proposed Changes
This pull request includes several changes to the
core-web
library, focusing on improvements to thedot-select-existing-content
component and its associated files. The changes involve updates to the SCSS file, HTML templates, TypeScript components, and the addition of new tests. Here are the most important changes:SCSS Changes:
_colors.scss
from$color-palette-primary-200
to$color-palette-primary-100
.HTML Template Changes:
RELATIONSHIP
indot-edit-content-field.component.html
.pagination.component.html
and added a new structure with conditional layout based on$currentPageReportLayout
.TypeScript Component Changes:
output
import and definedonSelectItems
signal to emit selected items indot-select-existing-content.component.ts
. [1] [2]Content
type withRelationshipFieldItem
and updated the store to usetapResponse
for handling content loading inexisting-content.store.ts
. [1] [2]Test Additions:
DotSelectExistingContentComponent
to validate dialog visibility, selected items state, and apply button label indot-select-existing-content.component.spec.ts
.These changes enhance the functionality and maintainability of the
dot-select-existing-content
component and its related parts.Checklist
This PR fixes: #30523