Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript-react-apollo): Apollo Client useFragment hook #483

Merged

Conversation

rickdunkin
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant
motivation and context. List any dependencies that are required for this change.

Related #482

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take
action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration

  • wrote a new test, updated a dev-test file, ran yarn build, yarn generate:examples, yarn test and all completed successfully
  • ran the updated code in my project at work and had useFragment hooks generated as expected

Test Environment:

  • OS: macOS Sonoma 14.1
  • @graphql-codegen/typescript-react-apollo@4.1.0:
  • NodeJS: 20.9.0

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

The solution(s) I came up with here may not be the most optimal, this is the first time I've looked through the code used for graphql-codegen so there could be better ways to do this

Copy link

changeset-bot bot commented Nov 5, 2023

🦋 Changeset detected

Latest commit: df425fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/typescript-react-apollo Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@rickdunkin
Copy link
Contributor Author

This has been open for a few weeks now, if there's anything else I need to do to get this merged please let me know

Copy link
Collaborator

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this and sorry for the delays

@saihaj saihaj merged commit ba7e551 into dotansimha:main Feb 2, 2024
14 checks passed
@github-actions github-actions bot mentioned this pull request Feb 2, 2024
@saihaj
Copy link
Collaborator

saihaj commented Feb 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants