Generate explicit type for variables used in a subscription to work with URQL v4 #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith urql v4 Otherwise it doesn't work if subscription have a required variable Possibly a breaking change - now it requires to define empty object for variables argument if no variables are used in subscription
🦋 Changeset detectedLatest commit: d6bf137 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
saihaj
reviewed
Feb 2, 2024
| @@ -0,0 +1,6 @@ | |||
| --- | |||
| '@graphql-codegen/typescript-vue-urql': minor | |||
There was a problem hiding this comment.
I think we should ship this as a breaking change cause I don't want users to have a surprise upgrading if we are making it more explicit
Suggested change
| '@graphql-codegen/typescript-vue-urql': minor | |
| '@graphql-codegen/typescript-vue-urql': major |
There was a problem hiding this comment.
The main breaking change in #328 was already released as I know, subscription part is not so widely used as I see from much less reactions, but lets do what is better for the project
|
@saihaj Any news on when this will be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generate explicit type for variables used in a subscription to work with URQL v4
This is basically the same as accepted #329 (comment) but for subscriptions.
Otherwise it doesn't compile generated files if subscription have a required variable.
WARNING: This is possibly a breaking change - now it requires to define empty object for variables argument if no variables are used in subscription
Related #328
Type of change
Please delete options that are not relevant.
expected)
Test Environment:
@graphql-codegen/typescript-vue-urql:Checklist:
CONTRIBUTING doc and the
style guidelines of this project