fix(typescript-graphql-request): Fix typescript error #549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the latest version of @graphql-codegen/typescript-graphql-request, TypeScript error occured when moduleResolution is set to "nodenext" or "bundler".
In the issue #501 various version error reported.
I tried with the latest version.
Here is my
tsconfig.json
. It is generated bytsc --init
and I changed the module to "nodenext".Somehow, the type of graphql-requests cannot be imported by filename.
My solution was to import "GraphQLRequestHeader" from "graphql-request" instead of "graphql-request/build/cjs/types".
This solution was proposed in this comment.
In addition, I tried "graphql-request" version on 5.0.0, 5.1.0, 5.2.0, 6.0.0, 6.1.0, It works.
Related #501
This Issue is already closed, but now error reported is commented here, I created this PR.
Type of change
Please delete options that are not relevant.
expected)
Screenshots/Sandbox (if appropriate/relevant):
Adding links to sandbox or providing screenshots can help us understand more about this PR and take
action on it as appropriate
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration
I don't know how to generate using local plugin, I tried to console.log output in test code this file, checked TypeScript error.
Test Environment:
Checklist:
CONTRIBUTING doc and the
style guidelines of this project
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose
the solution you did and what alternatives you considered, etc...