Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-query): importOperationTypesFrom missing prefix #552

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

neil585456525
Copy link
Contributor

@neil585456525 neil585456525 commented Dec 29, 2023

Description

Fix importOperationTypesFrom missing prefix.

Related #493 #434

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further Messages:

Thanks all of you who help to test and find issue for 6.0.0!
Special thanks to @knoefel for digging into the code and @groomain for creating the test repo!

Copy link

changeset-bot bot commented Dec 29, 2023

🦋 Changeset detected

Latest commit: 1adb67f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/typescript-react-query Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@neil585456525 neil585456525 changed the title Fix/react query type issue fix(react-query): importOperationTypesFrom missing prefix Dec 29, 2023
@neil585456525 neil585456525 marked this pull request as ready for review December 29, 2023 09:34
@neil585456525 neil585456525 marked this pull request as draft December 29, 2023 09:41
@neil585456525 neil585456525 marked this pull request as ready for review December 29, 2023 09:49
@kieranm
Copy link

kieranm commented Jan 17, 2024

@neil585456525 Anything we can do to support getting this merged? It's the last piece of the puzzle for us to upgrade to v5! Thanks!

@neil585456525
Copy link
Contributor Author

@saihaj Please review this pr when you available, thx!

@kieranm
Copy link

kieranm commented Feb 2, 2024

Hi @saihaj - would you be able to unblock us on this? Thanks!

Copy link
Collaborator

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! looks great!

@saihaj saihaj merged commit b403529 into dotansimha:main Feb 2, 2024
14 checks passed
@github-actions github-actions bot mentioned this pull request Feb 2, 2024
@saihaj
Copy link
Collaborator

saihaj commented Feb 2, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants