Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kotlin): Enum names must not contain typesPrefix or typesSuffix #606

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

tristanlins
Copy link
Contributor

@tristanlins tristanlins commented Feb 2, 2024

Description

When using typesSuffix with kotlin plugin, the enum Names are generated in enum class, but not when referencing them.

The schema:

enum UserRole {
    ADMIN
    USER
    EDITOR
}

input SearchUser {
    username: String
    email: String
    name: String
    role: UserRole = USER
}

The generated code:

package kotlin

data class GraphqlSearchUserTypeInput(
    val email: String? = null,
    val name: String? = null,
    val role: GraphqlUserRoleType? = GraphqlUserRoleType.USER,
    val username: String? = null
) {
  ...
}

enum class GraphqlUserRoleType(val label: String) {
      ADMINType("ADMIN"),
      EDITORType("EDITOR"),
      USERType("USER");
  ...
}

The names should be ADMIN, EDITOR and USER, but they are suffixed with typesSuffix.
This end up in invalid code, because val role: GraphqlUserRoleType? = GraphqlUserRoleType.USER, does not include the suffix.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots/Sandbox (if appropriate/relevant):

How Has This Been Tested?

  • Should omit typesPrefix/typesSuffix in enum names if the option is set

Test Environment:

  • OS: Linux
  • @graphql-codegen/kotlin: 3.0.0
  • NodeJS: v20.9.0

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Feb 2, 2024

🦋 Changeset detected

Latest commit: b9dbb43

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/kotlin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@saihaj
Copy link
Collaborator

saihaj commented Feb 2, 2024

Thank you!

@saihaj saihaj merged commit 926f515 into dotansimha:main Feb 2, 2024
14 checks passed
@github-actions github-actions bot mentioned this pull request Feb 2, 2024
@saihaj
Copy link
Collaborator

saihaj commented Feb 2, 2024

released @graphql-codegen/kotlin@3.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants