Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unused parameter in generated code #613

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

j0k3r
Copy link
Contributor

@j0k3r j0k3r commented Feb 5, 2024

Description

When using the default behavior (ie: config rawRequest as false), the generated code has a E unused variable which make TS yelling when TS options noUnusedParameters is true.

The fix is put that variable onlye when rawRequest is true.

Related #453
This is replacement of #454 (because OP doesn't reply)

I tried to add stuff inside dev-test but I failed to understand properly how can I achieve that. Happy to add them if someone point me to the right direction.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

How Has This Been Tested?

The generated code doesn't include the variable so TypeScript is happy.

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

…rs of the package.

When using the default behavior (ie: config `rawRequest` as `false`), the generated code has a `E` unused variable which make TS yelling when TS options `noUnusedParameters` is `true`.

The fix is put that variable onlye when `rawRequest` is `true`.
Copy link

changeset-bot bot commented Feb 5, 2024

🦋 Changeset detected

Latest commit: 4b4c143

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/typescript-generic-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@saihaj
Copy link
Collaborator

saihaj commented Feb 6, 2024

Thanks!

@saihaj saihaj merged commit ae45d38 into dotansimha:main Feb 6, 2024
14 checks passed
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
@j0k3r j0k3r deleted the fix/unused-parameter-generic-sdk branch February 6, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants