Fix/required variables in query hook #620
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently when a query has required variables, the passing of
variables
object isn't enforced in query hook args. This can cause runtime errors as if one doesn't specify the variables object at all, the types all are happy.This PR introduces a proposed fix to ensure that variables need to be passed in args, when there are some required variables in the query. Similar has been done already for the component generation, but looks like this wasn't taken into account then.
Related dotansimha/graphql-code-generator#2870
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
There are new test cases ensuring that variables added as a required field instead of optional, when some of the query variables are required.
I ran the tests locally and saw that they passed.
Test Environment:
@graphql-codegen/typescript-react-apollo
: 4.2.0Checklist:
CONTRIBUTING doc and the
style guidelines of this project