Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphql codegen typescript effect #665

Closed

Conversation

vecerek
Copy link
Contributor

@vecerek vecerek commented Mar 19, 2024

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.

Description

Implements a new GraphQL codegen plugin that outputs a client SDK written using Effect.

Related # (issue)

#664

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take
action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Environment:

  • OS: MacOS 14.2.1 (23C71)
  • @graphql-codegen/...:
  • NodeJS: v20.11.0

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

I've mostly followed the implementation of @graphql-codegen/typescript-graphql-request

Copy link

changeset-bot bot commented Mar 19, 2024

⚠️ No Changeset found

Latest commit: 2bd472f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vecerek vecerek force-pushed the graphql-codegen-typescript-effect branch from 1fb79b7 to 0e2210c Compare March 19, 2024 15:38
@vecerek vecerek marked this pull request as ready for review March 19, 2024 15:38
@vecerek vecerek force-pushed the graphql-codegen-typescript-effect branch 2 times, most recently from f03f4c4 to 7505ed9 Compare March 19, 2024 15:47
@vecerek vecerek closed this May 1, 2024
@vecerek vecerek force-pushed the graphql-codegen-typescript-effect branch from 332c2d6 to 2bd472f Compare May 1, 2024 14:29
@vecerek
Copy link
Contributor Author

vecerek commented May 2, 2024

I accidentally closed this PR while trying to sync my fork 🤦
Re-opened as #701

@vecerek vecerek mentioned this pull request May 2, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants