Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: address issues reported by yarn doctor #734

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

vecerek
Copy link
Contributor

@vecerek vecerek commented Jun 1, 2024

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.

Description

Addresses all issues uncovered by yarn doctor (yarn dlx @yarnpkg/doctor), specifically:

  • undeclared dependencies
  • strings referencing the node_modules directory

For more details: https://yarnpkg.com/migration/pnp#calling-the-doctor

Builds on top of #732 and #733 and takes one step closer to the potential adoption of PnP.

Related #735

Type of change

internal change: make all dependencies explicit

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take
action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Environment:

  • OS:
  • @graphql-codegen/...:
  • NodeJS:

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose
the solution you did and what alternatives you considered, etc...

Copy link

changeset-bot bot commented Jun 1, 2024

⚠️ No Changeset found

Latest commit: 4f11ff1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vecerek vecerek mentioned this pull request Jun 1, 2024
@vecerek vecerek changed the title Yarn doctor Address issues reported by yarn doctor Jun 1, 2024
@vecerek vecerek changed the title Address issues reported by yarn doctor chore: address issues reported by yarn doctor Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant