Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-vue-urql): variable typing #801

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

yurks
Copy link
Contributor

@yurks yurks commented Jul 31, 2024

Description

Generation template for vue urql query/subscription was changed in #329.
That was necessary due to changes in urql-vue lib, which caused a number of regressions. Currently, all of them was fixed and finally released with urql-vue@1.4.0

This PR basically reverts #329 and and fits urql-vue@1.4.0 changes.

Related #328
Related #403
Related dotansimha/graphql-code-generator#9421

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Was built and used in live internal project

Test Environment:

  • OS: MacOS
  • @graphql-codegen/typescript-vue-urql:
  • NodeJS: 20

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

urql-graphql/urql#3605

Copy link

changeset-bot bot commented Jul 31, 2024

🦋 Changeset detected

Latest commit: 678c1ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/typescript-vue-urql Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kitten
Copy link

kitten commented Jul 31, 2024

Not saying this isn't PR necessary, but in case people stumble upon this PR, we recommend TypedDocumentNode-based tools to be used for deriving types for GraphQL operations, even with @urql/vue bindings, since those reliably and universally work and align with GraphQL patterns more nicely.

Specifically, we'd recommend, if GraphQL Code Generator should still be used for people to migrate to the client-preset (which uses the typed-document-node plugin) or to gql.tada, a separate project (which is also maintained by the urql core team)

@saihaj saihaj merged commit 6970825 into dotansimha:main Aug 21, 2024
14 checks passed
@github-actions github-actions bot mentioned this pull request Sep 5, 2024
@saihaj
Copy link
Collaborator

saihaj commented Sep 5, 2024

Released @graphql-codegen/typescript-vue-urql@3.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants