fix(deps): move graphql-tag to devDeps from peerDeps for typescript-react-apollo
#805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1073e08 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
saihaj
reviewed
Aug 5, 2024
`graphql-tag` is only used in .spec files within the `typescript-react-apollo` package. Similar to `typescript-apollo-angular`, this commit moves `graphql-tag` to devDependencies so package consumers aren't required to install it to remove warning: ``` warning " > @graphql-codegen/typescript-react-apollo@4.3.0" has unmet peer dependency "graphql-tag@^2.0.0". ``` Signed-off-by: Scott Christopherson <scott@mondoo.com>
scottopherson
force-pushed
the
typescript-react-apollo/rm-graphql-tag
branch
from
623750b
to
1073e08
Compare
|
@saihaj yeah no problem |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
graphql-tagis only used in .spec files within thetypescript-react-apollopackage. Similar totypescript-apollo-angular, this commit movesgraphql-tagto devDependencies so package consumers aren't required to install it to remove warning:Related (issue)
Closes #471
Type of change
expected
How Has This Been Tested?
yarn installwarning is no longer displayed.Test Environment:
@graphql-codegen/typescript-react-apollo: 4.3.0Checklist:
CONTRIBUTING doc and the
style guidelines of this project