-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/c sharp member name casing #806
Fix/c sharp member name casing #806
Conversation
🦋 Changeset detectedLatest commit: f044f3c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you run yarn changeset
and explain the changes there so it can be part of release notes. Other than that seems reasonable to me
… pascal case) for a class' properties
…at it actually applies to all members, not only fields
a8cbe3b
to
4fe8faf
Compare
@saihaj I added the changeset with the type minor because there's no braking change, just new functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!
Besides this plugin ( Should I open a new issue or can I start working on the PR right away? I could also extend the description of #798 to mention the |
Thank you!
feel free to just send in the PR |
released @graphql-codegen/c-sharp@5.1.0 |
Description
Using new config option named
memberNameConvention
, the casing of the interface/class/record members can be controlled.Supported values are
camelCase
andpascalCase
.The default value is
camelCase
to avoid unexpected behaviour of this plugin from the people already using it.Related #798
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added tests for interface, class and records where both
camelCase
andpascalCase
naming is tested.Test Environment:
Checklist:
CONTRIBUTING doc and the
style guidelines of this project