fix: support errors with extensions set undefined

dotansimha · Jan 3, 2024 · 3ef877a · 3ef877a
1 parent d94dd1a
commit 3ef877a
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 1 deletion.
diff --git a/.changeset/metal-days-wink.md b/.changeset/metal-days-wink.md
@@ -0,0 +1,5 @@
+---
+'graphql-yoga': patch
+---
+
+Support errors with extensions set undefined
diff --git a/packages/graphql-yoga/__tests__/error-masking.spec.ts b/packages/graphql-yoga/__tests__/error-masking.spec.ts
@@ -464,4 +464,41 @@ describe('error masking', () => {
       ],
     });
   });
+
+  it('support errors with undefined extensions', async () => {
+    const yoga = createYoga({
+      logging: false,
+      context: () => {
+        const error = createGraphQLError('I like turtles');
+        Object.defineProperty(error, 'extensions', {
+          get() {
+            return undefined;
+          },
+        });
+        throw error;
+      },
+      schema: createSchema({
+        typeDefs: /* GraphQL */ `
+          type Query {
+            a: String!
+          }
+        `,
+      }),
+    });
+
+    const response = await yoga.fetch('http://yoga/graphql', {
+      method: 'POST',
+      headers: {
+        'content-type': 'application/json',
+      },
+      body: JSON.stringify({ query: '{ __typename }' }),
+    });
+    expect(await response.json()).toMatchObject({
+      errors: [
+        {
+          message: 'I like turtles',
+        },
+      ],
+    });
+  });
 });
diff --git a/packages/graphql-yoga/src/plugins/result-processor/regular.ts b/packages/graphql-yoga/src/plugins/result-processor/regular.ts
@@ -35,7 +35,7 @@ export function processRegularResult(
       !Array.isArray(executionResult) &&
       areGraphQLErrors(executionResult.errors) &&
       executionResult.errors.some(
-        err => !err.extensions.originalError || isGraphQLError(err.extensions.originalError),
+        err => !err.extensions?.originalError || isGraphQLError(err.extensions.originalError),
       ),
   );