Feature/custom directives

[giautm]

No description provided.

[fabien0102]

Nice! A little snipet to illustrate how it’s works maybe? :)

[fabien0102]

I guess I have my answer here ^^ ardatan/graphql-tools#518 I will try this today :)

[schickling]

Thanks a lot! This looks great @giautm!

As @fabien0102 mentioned, would be great if you could also add an example using this feature in this PR.

[giautm]

@schickling : I think we should have some unit-test, I'm a little worried when adding a new feature.
😢

[schickling]

I completely agree, @giautm. Would be great if you could add some testing setup. Either unit or integration tests.

[fabien0102]

Example added! It's works perfectly, nice job @giautm 😉

For the integration tests, we can use directly the examples projects with supertest, and just execute the README.md queries. It can be a good start and avoid to duplicate code. The good part is that each integration test must have a workable example associate (but it can also be a bad part ^^).

If this solution can fit with the project, I can begin to work on a POC and make a PR to open the discussion 😉

[schickling]

This looks really great! I've merged this already since the changes seem very straightforward.

@fabien0102 @giautm can you create a new PR for the testing setup? I'd recommend using ava or jest as a test runner/framework.

[fabien0102]

Always jest for me 😉 I write this in my personal todolist ^ ^

[fabien0102]

@schickling Please note that the example may not work due to the package version of graphql-yoga inside the example (https://github.com/graphcool/graphql-yoga/blob/master/examples/custom-directives/package.json)

I don't know yet how you deals with this, so carreful (I tried with yarn link locally)

(it can be a good idea to put lastest as graphql-yoga version to every examples 😉)

[sflahave]

I just tried the custom-directives example and it doesn't seem to work. The directive resolvers are never invoked.

[schickling]

@sflahave would you mind creating a new issue for this?

[sflahave]

Sure - actually it works after updating to v1.6.0. The example's package.json specifies v1.2.0 currently.

[schickling]

Thanks a lot @sflahave. Can you create a PR updating the example version then?

[sflahave]

@schickling - sure, I'd be happy to do that.
#215