Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic JWT plugin #1921

Merged
merged 19 commits into from
Jul 24, 2023
Merged

Generic JWT plugin #1921

merged 19 commits into from
Jul 24, 2023

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Oct 21, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2022

🦋 Changeset detected

Latest commit: c799699

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-yoga/plugin-jwt Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2022

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-yoga/plugin-jwt 1.0.0-alpha-20230724125312-c7996997 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2022

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}

     checks.......................................: 100.00% ✓ 256682      ✗ 0     
     data_received................................: 1.0 GB  8.7 MB/s
     data_sent....................................: 52 MB   432 kB/s
     http_req_blocked.............................: avg=1.99µs   min=1.2µs   med=1.7µs   max=2.3ms   p(90)=2.29µs   p(95)=2.6µs   
     http_req_connecting..........................: avg=24ns     min=0s      med=0s      max=2.24ms  p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=625.35µs min=300.4µs med=508.1µs max=25.63ms p(90)=899.9µs  p(95)=967.6µs 
       { expected_response:true }.................: avg=625.35µs min=300.4µs med=508.1µs max=25.63ms p(90)=899.9µs  p(95)=967.6µs 
     ✓ { mode:graphql-jit }.......................: avg=458.64µs min=300.4µs med=400.8µs max=20.08ms p(90)=482.97µs p(95)=544.33µs
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=980.91µs min=770.6µs med=891.5µs max=25.63ms p(90)=1ms      p(95)=1.22ms  
     ✓ { mode:graphql-response-cache }............: avg=536.87µs min=347.1µs med=476.8µs max=18.86ms p(90)=558.6µs  p(95)=630.8µs 
     ✓ { mode:graphql }...........................: avg=669.86µs min=445.9µs med=562.5µs max=22.69ms p(90)=733.5µs  p(95)=954.75µs
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 128341
     http_req_receiving...........................: avg=36.06µs  min=19.09µs med=30.9µs  max=11.71ms p(90)=45µs     p(95)=49.09µs 
     http_req_sending.............................: avg=16.63µs  min=7.1µs   med=10.2µs  max=6.9ms   p(90)=16.5µs   p(95)=18.39µs 
     http_req_tls_handshaking.....................: avg=0s       min=0s      med=0s      max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=572.64µs min=269µs   med=459.1µs max=25.56ms p(90)=855.4µs  p(95)=910.2µs 
     http_reqs....................................: 128341  1069.485016/s
     iteration_duration...........................: avg=927.88µs min=533.7µs med=803.6µs max=25.97ms p(90)=1.19ms   p(95)=1.29ms  
     iterations...................................: 128341  1069.485016/s
     vus..........................................: 1       min=1         max=1   
     vus_max......................................: 2       min=2         max=2   

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2022

💻 Website Preview

The latest changes are available as preview in: https://566932b3.graphql-yoga.pages.dev

Copy link
Collaborator

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing docs and tests

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023

Apollo Federation Subgraph Compatibility Results

Federation 1 SupportFederation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

@EmrysMyrddin EmrysMyrddin requested a review from n1ru4l July 10, 2023 19:09
Copy link
Collaborator

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with comments

@EmrysMyrddin EmrysMyrddin merged commit 4377151 into main Jul 24, 2023
@EmrysMyrddin EmrysMyrddin deleted the generic-jwt-plugin branch July 24, 2023 13:10
This was referenced May 7, 2024
This was referenced May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants