Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: no subscription via multipart/mixed #2810

Merged
merged 3 commits into from
May 30, 2023

Conversation

n1ru4l
Copy link
Collaborator

@n1ru4l n1ru4l commented May 29, 2023

Closes #2677

@n1ru4l n1ru4l requested review from enisdenjo and ardatan May 29, 2023 13:07
@changeset-bot
Copy link

changeset-bot bot commented May 29, 2023

🦋 Changeset detected

Latest commit: 457078e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
graphql-yoga Major
@graphql-yoga/nestjs Major
@graphql-yoga/render-graphiql Major
@graphql-yoga/plugin-apollo-inline-trace Major
@graphql-yoga/plugin-apq Major
@graphql-yoga/plugin-csrf-prevention Major
@graphql-yoga/plugin-defer-stream Major
@graphql-yoga/plugin-disable-introspection Major
@graphql-yoga/plugin-graphql-sse Major
@graphql-yoga/plugin-persisted-operations Major
@graphql-yoga/plugin-prometheus Major
@graphql-yoga/plugin-response-cache Major
@graphql-yoga/plugin-sofa Major
apollo-federation-gateway-with-yoga Patch
apollo-subgraph-with-yoga Patch
graphql-lambda Patch
cloudflare-advanced Patch
cloudflare Patch
functions Patch
graphql-yoga-cloud-run-guide Patch
hackernews Patch
nextjs-app Patch
hello-world-benchmark Patch
@graphql-yoga/nestjs-federation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ardatan ardatan changed the title test: no subscription via multipart/mixed [DO NOT MERGE YET] test: no subscription via multipart/mixed May 29, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2023

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}

     checks.......................................: 100.00% ✓ 349808      ✗ 0     
     data_received................................: 1.4 GB  12 MB/s
     data_sent....................................: 71 MB   589 kB/s
     http_req_blocked.............................: avg=1.43µs   min=800ns    med=1.2µs    max=1.12ms  p(90)=1.8µs    p(95)=2.1µs   
     http_req_connecting..........................: avg=5ns      min=0s       med=0s       max=429.5µs p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=453.92µs min=226.5µs  med=366.6µs  max=27.32ms p(90)=647.11µs p(95)=685.21µs
       { expected_response:true }.................: avg=453.92µs min=226.5µs  med=366.6µs  max=27.32ms p(90)=647.11µs p(95)=685.21µs
     ✓ { mode:graphql-jit }.......................: avg=338.37µs min=226.5µs  med=295.5µs  max=23.38ms p(90)=354.67µs p(95)=388.8µs 
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=705.61µs min=566.71µs med=642.81µs max=18.55ms p(90)=728.91µs p(95)=808.21µs
     ✓ { mode:graphql-response-cache }............: avg=390.52µs min=272.8µs  med=346.9µs  max=13.57ms p(90)=405.1µs  p(95)=443µs   
     ✓ { mode:graphql }...........................: avg=478.05µs min=340.9µs  med=406.7µs  max=27.32ms p(90)=490.71µs p(95)=570.11µs
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 174904
     http_req_receiving...........................: avg=25.39µs  min=14.5µs   med=21.5µs   max=9.34ms  p(90)=33.1µs   p(95)=37.8µs  
     http_req_sending.............................: avg=10.87µs  min=5.3µs    med=6.6µs    max=5.98ms  p(90)=11.1µs   p(95)=13.7µs  
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=417.64µs min=202.2µs  med=334.1µs  max=27.25ms p(90)=617.31µs p(95)=648.81µs
     http_reqs....................................: 174904  1457.498753/s
     iteration_duration...........................: avg=681.18µs min=419.7µs  med=590.21µs max=27.69ms p(90)=862.41µs p(95)=923.21µs
     iterations...................................: 174904  1457.498753/s
     vus..........................................: 1       min=1         max=1   
     vus_max......................................: 2       min=2         max=2   

@github-actions
Copy link
Contributor

Apollo Federation Subgraph Compatibility Results

Federation 1 SupportFederation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

@n1ru4l n1ru4l changed the title [DO NOT MERGE YET] test: no subscription via multipart/mixed feat: no subscription via multipart/mixed May 29, 2023
@n1ru4l n1ru4l marked this pull request as draft May 29, 2023 13:15
@github-actions
Copy link
Contributor

github-actions bot commented May 29, 2023

🚀 Snapshot Release (rc)

The latest changes of this PR are available as rc on npm (based on the declared changesets):

Package Version Info
graphql-yoga-cloud-run-guide 2.0.0-rc-20230529131633-457078e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/apollo-link 2.0.0-rc-20230529131633-457078e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/urql-exchange 2.0.0-rc-20230529131633-457078e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/redis-event-target 2.0.0-rc-20230529131633-457078e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/typed-event-target 2.0.0-rc-20230529131633-457078e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/graphiql 4.0.0-rc-20230529131633-457078e0 npm ↗︎ unpkg ↗︎
graphql-yoga 4.0.0-rc-20230529131633-457078e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/logger 1.0.0-rc-20230529131633-457078e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/nestjs 2.0.0-rc-20230529131633-457078e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/nestjs-federation 2.0.0-rc-20230529131633-457078e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apollo-inline-trace 2.0.0-rc-20230529131633-457078e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apq 2.0.0-rc-20230529131633-457078e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-csrf-prevention 2.0.0-rc-20230529131633-457078e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-defer-stream 2.0.0-rc-20230529131633-457078e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-disable-introspection 1.0.0-rc-20230529131633-457078e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-graphql-sse 2.0.0-rc-20230529131633-457078e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-persisted-operations 2.0.0-rc-20230529131633-457078e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-prometheus 2.0.0-rc-20230529131633-457078e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-response-cache 2.0.0-rc-20230529131633-457078e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-sofa 2.0.0-rc-20230529131633-457078e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/render-graphiql 4.0.0-rc-20230529131633-457078e0 npm ↗︎ unpkg ↗︎
@graphql-yoga/subscription 4.0.0-rc-20230529131633-457078e0 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

💻 Website Preview

The latest changes are available as preview in: https://821664e6.graphql-yoga.pages.dev

@ardatan ardatan marked this pull request as ready for review May 30, 2023 14:19
@ardatan ardatan merged commit ec318fe into main May 30, 2023
@ardatan ardatan deleted the no-subscription-over-incremental-delivery branch May 30, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v4] Limit available response protocols based on operation type
2 participants