-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(example): Implement GraphQL Subscriptions with Yoga and WebSockets in BunJS #3043
chore(example): Implement GraphQL Subscriptions with Yoga and WebSockets in BunJS #3043
Conversation
|
function afterEach() { | ||
server.stop(); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we test WS here?
} | ||
|
||
it('shows GraphiQL', async () => { | ||
beforeEach(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not using the beforeEach
and afterEach
lifecycle hooks instead of manually calling setup and tear down functions ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I wrote this test, Bun didn't have those hooks :/ Not sure if it has now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loookig at the documentation, it should :-) I don't know when they added them
✅ Benchmark Results
|
This PR provides an example of integrating GraphQL subscriptions using WebSockets in BunJS, leveraging
makeHandler
api provided by graphql-ws.👉 #3041