Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @graphql-tools/executor-http for better SSE stream chunks and messages handling #3118

Merged
merged 4 commits into from
Nov 28, 2023

Conversation

enisdenjo
Copy link
Collaborator

Copy link

changeset-bot bot commented Nov 28, 2023

🦋 Changeset detected

Latest commit: d394b76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@graphql-yoga/apollo-link Patch
@graphql-yoga/urql-exchange Patch
@graphql-yoga/plugin-defer-stream Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 28, 2023

Apollo Federation Subgraph Compatibility Results

Federation 1 SupportFederation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

Copy link
Contributor

github-actions bot commented Nov 28, 2023

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}

     checks.......................................: 100.00% ✓ 394856      ✗ 0     
     data_received................................: 1.6 GB  13 MB/s
     data_sent....................................: 80 MB   664 kB/s
     http_req_blocked.............................: avg=1.58µs   min=1.04µs   med=1.39µs   max=776.27µs p(90)=2.09µs   p(95)=2.3µs   
     http_req_connecting..........................: avg=2ns      min=0s       med=0s       max=151.56µs p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=388.83µs min=219.73µs med=341.57µs max=18.42ms  p(90)=544.24µs p(95)=565.55µs
       { expected_response:true }.................: avg=388.83µs min=219.73µs med=341.57µs max=18.42ms  p(90)=544.24µs p(95)=565.55µs
     ✓ { mode:graphql-jit }.......................: avg=294.53µs min=219.73µs med=272.75µs max=18.42ms  p(90)=302.93µs p(95)=317.02µs
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=576.82µs min=473.92µs med=543.47µs max=12.44ms  p(90)=592.19µs p(95)=643.6µs 
     ✓ { mode:graphql-response-cache }............: avg=359.98µs min=279.86µs med=340.67µs max=16.75ms  p(90)=372.09µs p(95)=384.76µs
     ✓ { mode:graphql }...........................: avg=388.54µs min=297.78µs med=354.04µs max=12.71ms  p(90)=402.08µs p(95)=447.18µs
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 197428
     http_req_receiving...........................: avg=34.34µs  min=17.99µs  med=34.11µs  max=2.29ms   p(90)=40.33µs  p(95)=42.75µs 
     http_req_sending.............................: avg=9.01µs   min=5.94µs   med=8.08µs   max=608.29µs p(90)=11.62µs  p(95)=12.92µs 
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=345.48µs min=183.79µs med=299.06µs max=18.28ms  p(90)=500.68µs p(95)=520.19µs
     http_reqs....................................: 197428  1645.206533/s
     iteration_duration...........................: avg=602.84µs min=389.64µs med=552.24µs max=18.94ms  p(90)=761.15µs p(95)=787.2µs 
     iterations...................................: 197428  1645.206533/s
     vus..........................................: 1       min=1         max=1   
     vus_max......................................: 2       min=2         max=2   

Copy link
Contributor

github-actions bot commented Nov 28, 2023

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-yoga/apollo-link 3.0.1-alpha-20231128130554-d394b76e npm ↗︎ unpkg ↗︎
@graphql-yoga/urql-exchange 3.0.1-alpha-20231128130554-d394b76e npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apq 3.0.1-alpha-20231128130554-d394b76e npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-defer-stream 3.0.1-alpha-20231128130554-d394b76e npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Nov 28, 2023

💻 Website Preview

The latest changes are available as preview in: https://fe20825d.graphql-yoga.pages.dev

@enisdenjo enisdenjo merged commit 694e78b into main Nov 28, 2023
26 of 28 checks passed
@enisdenjo enisdenjo deleted the http-exec branch November 28, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant