-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Apply CSRF prevention validation only to GET requests #3146
Merged
enisdenjo
merged 3 commits into
dotansimha:main
from
holzerch:fix/csrf-prevention-plugin
Dec 29, 2023
Merged
fix: Apply CSRF prevention validation only to GET requests #3146
enisdenjo
merged 3 commits into
dotansimha:main
from
holzerch:fix/csrf-prevention-plugin
Dec 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3d3129d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I changed the initial implementation of the PR again to consider the content types browsers do preflight checks already. |
enisdenjo
approved these changes
Dec 29, 2023
Thank you @holzerch, this looks great! |
✅ Benchmark Results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of the CSRF prevention plugin requires special headers to be present on all requests. However in order to prevent CSRF attacks the check must only be done on some requests. For POST requests the browser does automatic preflight checks already for all content types not matching
application/x-www-form-urlencoded
,multipart/form-data
,text/plain