Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin/prometheus] Fix duplicated metrics #3251

Merged
merged 13 commits into from
May 8, 2024

Conversation

EmrysMyrddin
Copy link
Collaborator

No description provided.

Copy link

changeset-bot bot commented Apr 29, 2024

🦋 Changeset detected

Latest commit: 9462680

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-yoga/plugin-prometheus Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@EmrysMyrddin EmrysMyrddin requested a review from ardatan April 29, 2024 08:17
Copy link
Contributor

github-actions bot commented Apr 29, 2024

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

Copy link
Contributor

github-actions bot commented Apr 29, 2024

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}

     checks.......................................: 100.00% ✓ 403820      ✗ 0     
     data_received................................: 1.6 GB  14 MB/s
     data_sent....................................: 82 MB   679 kB/s
     http_req_blocked.............................: avg=1.43µs   min=992ns    med=1.28µs   max=298.45µs p(90)=1.89µs   p(95)=2.1µs   
     http_req_connecting..........................: avg=2ns      min=0s       med=0s       max=139.55µs p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=385.19µs min=218.79µs med=340.96µs max=24.16ms  p(90)=535.61µs p(95)=556.49µs
       { expected_response:true }.................: avg=385.19µs min=218.79µs med=340.96µs max=24.16ms  p(90)=535.61µs p(95)=556.49µs
     ✓ { mode:graphql-jit }.......................: avg=287.86µs min=218.79µs med=265.72µs max=18.41ms  p(90)=299.14µs p(95)=313.79µs
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=565.14µs min=472.23µs med=533.66µs max=10.2ms   p(90)=577.79µs p(95)=613.86µs
     ✓ { mode:graphql-response-cache }............: avg=366.61µs min=290.06µs med=345.76µs max=9.07ms   p(90)=380.23µs p(95)=392.95µs
     ✓ { mode:graphql }...........................: avg=383.96µs min=297.84µs med=347.1µs  max=24.16ms  p(90)=395.83µs p(95)=459.82µs
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 201910
     http_req_receiving...........................: avg=32.67µs  min=17.29µs  med=32.55µs  max=2.07ms   p(90)=38.53µs  p(95)=40.89µs 
     http_req_sending.............................: avg=7.97µs   min=5.75µs   med=7.11µs   max=5.21ms   p(90)=10.54µs  p(95)=11.28µs 
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=344.55µs min=186.59µs med=301.21µs max=24ms     p(90)=494.91µs p(95)=513.41µs
     http_reqs....................................: 201910  1682.562496/s
     iteration_duration...........................: avg=589.53µs min=386.94µs med=541.66µs max=24.9ms   p(90)=743.49µs p(95)=769.55µs
     iterations...................................: 201910  1682.562496/s
     vus..........................................: 1       min=1         max=1   
     vus_max......................................: 2       min=2         max=2   

Copy link
Contributor

github-actions bot commented Apr 29, 2024

💻 Website Preview

The latest changes are available as preview in: https://addc7035.graphql-yoga.pages.dev

Copy link
Contributor

github-actions bot commented Apr 29, 2024

🚀 Snapshot Release (rc)

The latest changes of this PR are available as rc on npm (based on the declared changesets):

Package Version Info
graphql-yoga-cloud-run-guide 3.3.1-rc-20240508081241-94626808 npm ↗︎ unpkg ↗︎
@graphql-yoga/apollo-link 3.3.1-rc-20240508081241-94626808 npm ↗︎ unpkg ↗︎
@graphql-yoga/urql-exchange 3.3.1-rc-20240508081241-94626808 npm ↗︎ unpkg ↗︎
graphql-yoga 5.3.1-rc-20240508081241-94626808 npm ↗︎ unpkg ↗︎
@graphql-yoga/nestjs 3.3.1-rc-20240508081241-94626808 npm ↗︎ unpkg ↗︎
@graphql-yoga/nestjs-federation 3.3.1-rc-20240508081241-94626808 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apollo-inline-trace 3.3.1-rc-20240508081241-94626808 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apq 3.3.1-rc-20240508081241-94626808 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-csrf-prevention 3.3.1-rc-20240508081241-94626808 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-defer-stream 3.3.1-rc-20240508081241-94626808 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-disable-introspection 2.3.1-rc-20240508081241-94626808 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-graphql-sse 3.3.1-rc-20240508081241-94626808 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-jwt 2.3.1-rc-20240508081241-94626808 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-persisted-operations 3.3.1-rc-20240508081241-94626808 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-prometheus 5.0.0-rc-20240508081241-94626808 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-response-cache 3.5.1-rc-20240508081241-94626808 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-sofa 3.3.1-rc-20240508081241-94626808 npm ↗︎ unpkg ↗︎
@graphql-yoga/render-graphiql 5.3.1-rc-20240508081241-94626808 npm ↗︎ unpkg ↗︎

@EmrysMyrddin EmrysMyrddin force-pushed the fix-prometheus-duplicated-metrics branch from ee67094 to 790e620 Compare April 29, 2024 15:10
@EmrysMyrddin EmrysMyrddin force-pushed the fix-prometheus-duplicated-metrics branch from 450574a to e4fdacf Compare May 7, 2024 14:26
@EmrysMyrddin EmrysMyrddin merged commit a8ddac5 into main May 8, 2024
27 of 28 checks passed
@EmrysMyrddin EmrysMyrddin deleted the fix-prometheus-duplicated-metrics branch May 8, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants