Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support shouldPersistHeaders option in GraphiQL plugin #3255

Merged
merged 2 commits into from
May 15, 2024

Conversation

nissy-dev
Copy link
Contributor

This PR added support for the shouldPersistHeaders option to the graphiql plugin.

Copy link

changeset-bot bot commented May 1, 2024

🦋 Changeset detected

Latest commit: 555227f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
graphql-yoga Minor
@graphql-yoga/graphiql Minor
@graphql-yoga/nestjs Major
@graphql-yoga/render-graphiql Major
@graphql-yoga/plugin-apollo-inline-trace Major
@graphql-yoga/plugin-apq Major
@graphql-yoga/plugin-csrf-prevention Major
@graphql-yoga/plugin-defer-stream Major
@graphql-yoga/plugin-disable-introspection Major
@graphql-yoga/plugin-graphql-sse Major
@graphql-yoga/plugin-jwt Major
@graphql-yoga/plugin-persisted-operations Major
@graphql-yoga/plugin-prometheus Major
@graphql-yoga/plugin-response-cache Major
@graphql-yoga/plugin-sofa Major
apollo-federation-gateway-with-yoga Patch
apollo-subgraph-with-yoga Patch
graphql-lambda Patch
cloudflare-advanced Patch
cloudflare Patch
functions Patch
nextjs-app Patch
hello-world-benchmark Patch
@graphql-yoga/nestjs-federation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nissy-dev nissy-dev changed the title feat: support shouldPersistHeaders option in GraphiQL feat: support shouldPersistHeaders option in GraphiQL plugin May 1, 2024
@EmrysMyrddin
Copy link
Collaborator

Hi! Thank you for your contribution! Can you add a changeset ?

Just run pnpm run changeset and follow instructions :-)

@nissy-dev
Copy link
Contributor Author

@EmrysMyrddin Thank you for your comments! I added a changeset!

@n1ru4l n1ru4l merged commit 7335a82 into dotansimha:main May 15, 2024
25 checks passed
Copy link
Contributor

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}

     checks.......................................: 100.00% ✓ 389624      ✗ 0     
     data_received................................: 1.6 GB  13 MB/s
     data_sent....................................: 79 MB   655 kB/s
     http_req_blocked.............................: avg=1.52µs   min=972ns    med=1.34µs   max=272µs    p(90)=2.01µs   p(95)=2.22µs  
     http_req_connecting..........................: avg=2ns      min=0s       med=0s       max=143.2µs  p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=396.98µs min=218.73µs med=352.14µs max=23.97ms  p(90)=554.91µs p(95)=576.99µs
       { expected_response:true }.................: avg=396.98µs min=218.73µs med=352.14µs max=23.97ms  p(90)=554.91µs p(95)=576.99µs
     ✓ { mode:graphql-jit }.......................: avg=299.4µs  min=218.73µs med=277.13µs max=15ms     p(90)=307.47µs p(95)=320.84µs
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=585.62µs min=485.3µs  med=553.64µs max=10.6ms   p(90)=602µs    p(95)=644.88µs
     ✓ { mode:graphql-response-cache }............: avg=376.19µs min=299.23µs med=356.91µs max=6.3ms    p(90)=387.55µs p(95)=399.08µs
     ✓ { mode:graphql }...........................: avg=391.84µs min=301.73µs med=358.42µs max=23.97ms  p(90)=408.95µs p(95)=456.73µs
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 194812
     http_req_receiving...........................: avg=33.8µs   min=17.45µs  med=33.67µs  max=1.06ms   p(90)=39.65µs  p(95)=41.91µs 
     http_req_sending.............................: avg=8.7µs    min=5.94µs   med=7.71µs   max=575.56µs p(90)=11.27µs  p(95)=12.48µs 
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=354.46µs min=190.99µs med=310.59µs max=23.81ms  p(90)=511.14µs p(95)=531.26µs
     http_reqs....................................: 194812  1623.415475/s
     iteration_duration...........................: avg=610.98µs min=402.92µs med=561.95µs max=24.77ms  p(90)=773.45µs p(95)=800.47µs
     iterations...................................: 194812  1623.415475/s
     vus..........................................: 1       min=1         max=1   
     vus_max......................................: 2       min=2         max=2   

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants