-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jwt] fix typo in plugin options name #3426
Conversation
🦋 Changeset detectedLatest commit: d737143 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
27b8a88
to
9238163
Compare
✅ Benchmark Results
|
Apollo Federation Subgraph Compatibility Results
Learn more: |
add8733
to
d737143
Compare
💻 Website PreviewThe latest changes are available as preview in: https://b2256dac.graphql-yoga.pages.dev |
@@ -539,7 +539,7 @@ describe('jwt plugin', () => { | |||
const secret = 'topsecret'; | |||
const test = createTestServer( | |||
{ | |||
singingKeyProviders: [createInlineSigningKeyProvider(secret)], | |||
signingKeyProviders: [createInlineSigningKeyProvider(secret)], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test for the backward compatibility to prevent future regressions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean you want the old misspelled option should continue to work and we should have a test for this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Until we completely remove it, let's make sure it works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh i just realized this change would break the existing users because it needs signing one as required while the old one is optional now. A union type would be better no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aaaah you're right ! I will fix this and add test
No description provided.