-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pass context to onParams hook #3464
Conversation
🦋 Changeset detectedLatest commit: 65c4ec6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 24 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1246771
to
4f592ca
Compare
Apollo Federation Subgraph Compatibility Results
Learn more: |
💻 Website PreviewThe latest changes are available as preview in: https://d1ebd460.graphql-yoga.pages.dev |
✅ Benchmark Results
|
4f592ca
to
670bbc2
Compare
@@ -0,0 +1,5 @@ | |||
--- | |||
'graphql-yoga': minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are sure that the type change can't break any existing usage ? I always fear how TS handles generics when we add one like this ><'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it has a default value, so it should be fine.
Alternative approach for #3463
This is required for solving graphql-hive/console#5875 as the request can not be used as a internal cache key for batched requests.