Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark createLRUCache as an internal utility #3588

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Dec 24, 2024

Mark createLRUCache utility as deprecated, and export it as _createLRUCache marking it as an
internal utility

Copy link

changeset-bot bot commented Dec 24, 2024

🦋 Changeset detected

Latest commit: 17eb81b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
graphql-yoga Patch
@graphql-yoga/nestjs Patch
@graphql-yoga/render-graphiql Patch
@graphql-yoga/plugin-apollo-inline-trace Patch
@graphql-yoga/apollo-managed-federation Patch
@graphql-yoga/plugin-apollo-usage-report Patch
@graphql-yoga/plugin-apq Patch
@graphql-yoga/plugin-csrf-prevention Patch
@graphql-yoga/plugin-defer-stream Patch
@graphql-yoga/plugin-disable-introspection Patch
@graphql-yoga/plugin-graphql-sse Patch
@graphql-yoga/plugin-jwt Patch
@graphql-yoga/plugin-persisted-operations Patch
@graphql-yoga/plugin-prometheus Patch
@graphql-yoga/plugin-response-cache Patch
@graphql-yoga/plugin-sofa Patch
apollo-federation-gateway-with-yoga Patch
apollo-subgraph-with-yoga Patch
graphql-lambda Patch
cloudflare-advanced Patch
cloudflare Patch
nextjs-app Patch
hello-world-benchmark Patch
@graphql-yoga/nestjs-federation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

Copy link
Contributor

💻 Website Preview

The latest changes are available as preview in: https://888ef6e0.graphql-yoga.pages.dev

Copy link
Contributor

github-actions bot commented Dec 24, 2024

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}
     ✓ no_errors{mode:uws}
     ✓ expected_result{mode:uws}

     checks.......................................: 100.00% ✓ 516748      ✗ 0     
     data_received................................: 2.1 GB  14 MB/s
     data_sent....................................: 104 MB  692 kB/s
     http_req_blocked.............................: avg=1.49µs   min=992ns    med=1.32µs   max=266.81µs p(90)=1.95µs   p(95)=2.14µs  
     http_req_connecting..........................: avg=2ns      min=0s       med=0s       max=145.84µs p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=363.46µs min=217.4µs  med=330.8µs  max=14.87ms  p(90)=470.56µs p(95)=492.96µs
       { expected_response:true }.................: avg=363.46µs min=217.4µs  med=330.8µs  max=14.87ms  p(90)=470.56µs p(95)=492.96µs
     ✓ { mode:graphql-jit }.......................: avg=293.52µs min=217.4µs  med=275.96µs max=14.87ms  p(90)=309.38µs p(95)=327.55µs
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=495.28µs min=409.21µs med=471.59µs max=5.74ms   p(90)=514.43µs p(95)=569.5µs 
     ✓ { mode:graphql-response-cache }............: avg=344.36µs min=265.09µs med=326.48µs max=6.38ms   p(90)=357.84µs p(95)=369.9µs 
     ✓ { mode:graphql }...........................: avg=375.19µs min=283.17µs med=345.85µs max=14.44ms  p(90)=412.92µs p(95)=460.19µs
     ✓ { mode:uws }...............................: avg=344.95µs min=270.48µs med=328.32µs max=6.96ms   p(90)=362.91µs p(95)=383.22µs
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 258374
     http_req_receiving...........................: avg=33.11µs  min=15.5µs   med=32.75µs  max=2.67ms   p(90)=39.33µs  p(95)=41.85µs 
     http_req_sending.............................: avg=8.63µs   min=6.02µs   med=7.55µs   max=654.25µs p(90)=11.14µs  p(95)=12.09µs 
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=321.71µs min=188.14µs med=290.05µs max=14.76ms  p(90)=428.61µs p(95)=449.15µs
     http_reqs....................................: 258374  1722.475482/s
     iteration_duration...........................: avg=575.67µs min=392.77µs med=538.69µs max=15.42ms  p(90)=685.73µs p(95)=713.43µs
     iterations...................................: 258374  1722.475482/s
     vus..........................................: 1       min=1         max=1   
     vus_max......................................: 2       min=2         max=2   

@ardatan ardatan merged commit ed344ea into main Dec 24, 2024
24 checks passed
@ardatan ardatan deleted the create-lru-cache-prefix branch December 24, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants