Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] node dashboard only shows latest instance #102

Closed
uhthomas opened this issue Feb 25, 2024 · 2 comments
Closed

[bug] node dashboard only shows latest instance #102

uhthomas opened this issue Feb 25, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@uhthomas
Copy link
Contributor

Describe the bug

Some panels are using node to filter, and others are using a hidden instance variable ( label_values(node_uname_info{nodename=~"(?i:($node))"}, instance)). If a node changes its IP, then some panels will look normal and others will be missing data.

image

How to reproduce?

  1. Collect node metrics.
  2. Change IP of node.
  3. Observe the node dashboard has some unaffected panels, and others which only show the latest 'instance'.

Expected behavior

It should probably show all instances of a node.

Additional context

No response

@uhthomas uhthomas added the bug Something isn't working label Feb 25, 2024
@dotdc
Copy link
Owner

dotdc commented Apr 3, 2024

Hi @uhthomas,

I've been thinking about this and don't see a fix for this one.
The node / instance hack was used to have convenient names while using the dashboard, I'd like to keep it that way.

For me, a node changing IP is a rare corner case, but I guess it depends on your setup.

How often do you have IP changes on your nodes?

dotdc added a commit that referenced this issue Apr 26, 2024
Signed-off-by: David Calvert <david@0xdc.me>
@dotdc
Copy link
Owner

dotdc commented Apr 26, 2024

Documented in 34a469f

@dotdc dotdc closed this as completed Apr 26, 2024
sdlarsen pushed a commit to digital-science/grafana-dashboards-kubernetes that referenced this issue Apr 26, 2024
Signed-off-by: David Calvert <david@0xdc.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants