Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to unwrap with and_then. Also it was wrongly wrapped with Some. #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rofrol
Copy link

@rofrol rofrol commented Aug 29, 2020

No description provided.

@codecov
Copy link

codecov bot commented Aug 29, 2020

Codecov Report

Merging #62 into master will increase coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
+ Coverage   86.77%   87.13%   +0.36%     
==========================================
  Files           7        7              
  Lines         242      241       -1     
==========================================
  Hits          210      210              
+ Misses         32       31       -1     
Impacted Files Coverage Δ
dotenv/src/lib.rs 100.00% <ø> (ø)
dotenv/src/find.rs 90.90% <0.00%> (+3.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c1a77b...f389650. Read the comment docs.

allan2 referenced this pull request in allan2/dotenvy Feb 28, 2022
The following is also duplicated in the changelog.

- `dotenv` crate forked as `dotenvy`
- `dotenv_codegen` forked as `dotenvy_codgen`
- `dotenv_codegen_implementation` forked as `dotenvy_codegen_impl`
- Crate description for dotenvy_codegen
- Crate description for dotenvy_codgen_impl
- New language in README
- MIT license badge in README
- Generate helpful errors from dotenv! macro (full merge of [dotenv-rs/dotenv #58](https://github.com/dotenv-rs/dotenv/pull/57/files#))

- replaced deprecated `std::env_home:dir()` with `dirs:home_dir`
- Better handling of `home_dir` (merge of [dotenv-rs/dotenv #62](https://github.com/dotenv-rs/dotenv/pull/62/files#))
- assertions dealing with `Result` (based on [dotenv-rs/dotenv #57](https://github.com/dotenv-rs/dotenv/pull/57/files#))
- upgraded clap in `dotenvy` bin from v2 to v3.1 (covers [dotenv-rs/dotenv #76](https://github.com/dotenv-rs/dotenv/pull/76/files))

- example folder. The simple example has been moved to the README.
- `extern`
- unnecessary `use` statements in doc examples
@hoijui
Copy link

hoijui commented Mar 7, 2022

This is fixed in the new repo:
https://github.com/allan2/dotenvy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants