requested changes

dotkernel · Oct 25, 2023 · 6d2db3f · 6d2db3f
1 parent c68bd83
commit 6d2db3f
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 24 deletions.
diff --git a/README.md b/README.md
@@ -4,16 +4,14 @@ Dotkernel web starter package suitable for frontend applications.
 
 
 ![OSS Lifecycle](https://img.shields.io/osslifecycle/dotkernel/frontend)
-
+![PHP from Packagist (specify version)](https://img.shields.io/packagist/php-v/dotkernel/frontend/4.0.0)
 
 [![GitHub issues](https://img.shields.io/github/issues/dotkernel/frontend)](https://github.com/dotkernel/frontend/issues)
 [![GitHub forks](https://img.shields.io/github/forks/dotkernel/frontend)](https://github.com/dotkernel/frontend/network)
 [![GitHub stars](https://img.shields.io/github/stars/dotkernel/frontend)](https://github.com/dotkernel/frontend/stargazers)
 [![GitHub license](https://img.shields.io/github/license/dotkernel/frontend)](https://github.com/dotkernel/frontend/blob/4.0/LICENSE.md)
 
 
-![PHP from Packagist (specify version)](https://img.shields.io/packagist/php-v/dotkernel/frontend/4.0.0)
-
 [![Build Static](https://github.com/dotkernel/frontend/actions/workflows/static-analysis.yml/badge.svg?branch=4.0)](https://github.com/dotkernel/frontend/actions/workflows/static-analysis.yml)
 [![Build Static](https://github.com/dotkernel/frontend/actions/workflows/run-tests.yml/badge.svg?branch=4.0)](https://github.com/dotkernel/frontend/actions/workflows/run-tests.yml)
 [![codecov](https://codecov.io/gh/dotkernel/frontend/graph/badge.svg?token=BQS43UWAM4)](https://codecov.io/gh/dotkernel/frontend)

diff --git a/src/App/src/ConfigProvider.php b/src/App/src/ConfigProvider.php
@@ -18,19 +18,8 @@
 use Mezzio\Application;
 use Roave\PsrContainerDoctrine\EntityManagerFactory;
 
-/**
- * The configuration provider for the App module
- *
- * @see https://docs.laminas.dev/laminas-component-installer/
- */
 class ConfigProvider
 {
-    /**
-     * Returns the configuration array
-     *
-     * To add a bit of a structure, each section is defined in a separate
-     * method which returns an array with its configuration.
-     */
     public function __invoke(): array
     {
         return [
@@ -40,9 +29,6 @@ public function __invoke(): array
         ];
     }
 
-    /**
-     * Returns the container dependencies
-     */
     public function getDependencies(): array
     {
         return [
@@ -79,9 +65,6 @@ public function getDoctrineConfig(): array
         ];
     }
 
-    /**
-     * Returns the templates configuration
-     */
     public function getTemplates(): array
     {
         return [

diff --git a/src/User/src/Service/UserService.php b/src/User/src/Service/UserService.php
@@ -8,6 +8,7 @@
 use Doctrine\ORM\NonUniqueResultException;
 use Dot\AnnotatedServices\Annotation\Inject;
 use Dot\AnnotatedServices\Annotation\Service;
+use Dot\Mail\Exception\MailException;
 use Dot\Mail\Service\MailService;
 use Exception;
 use Frontend\App\Common\Message;
@@ -228,6 +229,9 @@ public function exists(string $email = '', ?string $uuid = ''): bool
         );
     }
 
+    /**
+     * @throws MailException
+     */
     public function sendActivationMail(User $user): bool
     {
         if ($user->isActive()) {
@@ -286,6 +290,9 @@ public function findByResetPasswordHash(?string $hash): ?User
         return $this->userRepository->findByResetPasswordHash($hash);
     }
 
+    /**
+     * @throws MailException
+     */
     public function sendResetPasswordCompletedMail(User $user): bool
     {
         $this->mailService->setBody(

diff --git a/test/Common/FormTrait.php b/test/Common/FormTrait.php
@@ -18,8 +18,8 @@ protected function formWillInstantiate(string $class): void
     {
         $this->assertInstanceOf($class, new $class());
         $this->assertInstanceOf($class, new $class(null, []));
-        $this->assertInstanceOf($class, new $class('accountForm'));
-        $this->assertInstanceOf($class, new $class('accountForm', []));
+        $this->assertInstanceOf($class, new $class('form'));
+        $this->assertInstanceOf($class, new $class('form', []));
     }
 
     protected function formHasElements(FormInterface $form, array $elements = []): void

diff --git a/test/Unit/App/Common/AbstractEntityTest.php b/test/Unit/App/Common/AbstractEntityTest.php
@@ -17,7 +17,7 @@ public static function setUpBeforeClass(): void
         self::$entity = new class extends AbstractEntity {
             public mixed $value;
 
-            public function setValue(mixed $value)
+            public function setValue(mixed $value): void
             {
                 $this->value = $value;
             }
@@ -27,7 +27,7 @@ public function getValue(): mixed
                 return $this->value;
             }
 
-            public function addValue(mixed $value)
+            public function addValue(mixed $value): void
             {
                 $this->value = $value;
             }