Remove dead code from Composition.Hosting (dotnet#35131)

dotnet-maestro-bot · Feb 7, 2019 · 4d18056 · 4d18056
1 parent a27099d
commit 4d18056
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 20 deletions.
diff --git a/src/System.Composition.Hosting/src/Resources/Strings.resx b/src/System.Composition.Hosting/src/Resources/Strings.resx
@@ -116,12 +116,6 @@
   <data name="Formatter_ListSeparatorWithSpace" xml:space="preserve">
     <value>, </value>
   </data>
-  <data name="Dependency_Not_In_Error_State" xml:space="preserve">
-    <value>Dependency is not in an error state.</value>
-  </data>
-  <data name="Sharing_Lock_Required" xml:space="preserve">
-    <value>Sharing lock is required</value>
-  </data>
   <data name="Sharing_Lock_Taken" xml:space="preserve">
     <value>Sharing lock already taken in this operation.</value>
   </data>

diff --git a/src/System.Composition.Hosting/src/System/Composition/Hosting/CompositionHost.cs b/src/System.Composition.Hosting/src/System/Composition/Hosting/CompositionHost.cs
@@ -8,6 +8,7 @@
 using System.Composition.Hosting.Providers.ExportFactory;
 using System.Composition.Hosting.Providers.ImportMany;
 using System.Composition.Hosting.Providers.Lazy;
+using System.Diagnostics;
 using System.Linq;
 
 namespace System.Composition.Hosting
@@ -24,11 +25,7 @@ public sealed class CompositionHost : CompositionContext, IDisposable
 
         private CompositionHost(LifetimeContext rootLifetimeContext)
         {
-            if(rootLifetimeContext == null)
-            {
-                throw new ArgumentNullException(nameof(rootLifetimeContext));
-            }
-
+            Debug.Assert(rootLifetimeContext != null);
             _rootLifetimeContext = rootLifetimeContext;
         }
 

diff --git a/src/System.Composition.Hosting/src/System/Composition/Hosting/Core/CompositionDependency.cs b/src/System.Composition.Hosting/src/System/Composition/Hosting/Core/CompositionDependency.cs
@@ -4,6 +4,7 @@
 
 using System.Collections.Generic;
 using System.Composition.Hosting.Util;
+using System.Diagnostics;
 using System.Linq;
 using System.Text;
 
@@ -168,10 +169,7 @@ public override string ToString()
 
         internal void DescribeError(StringBuilder message)
         {
-            if(!IsError)
-            {
-                throw new Exception(SR.Dependency_Not_In_Error_State);
-            }
+            Debug.Assert(IsError, "Should be in error state.");
 
             if (_oversuppliedTargets != null)
             {

diff --git a/src/System.Composition.Hosting/src/System/Composition/Hosting/Core/CompositionOperation.cs b/src/System.Composition.Hosting/src/System/Composition/Hosting/Core/CompositionOperation.cs
@@ -3,6 +3,7 @@
 // See the LICENSE file in the project root for more information.
 
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.Threading;
 
 namespace System.Composition.Hosting.Core
@@ -84,10 +85,7 @@ public void AddPostCompositionAction(Action action)
 
         internal void EnterSharingLock(object sharingLock)
         {
-            if (sharingLock == null)
-            {
-                throw new ArgumentException(SR.Sharing_Lock_Required);
-            }
+            Debug.Assert(sharingLock != null, "Expected a sharing lock to be passed.");
 
             if (_sharingLock == null)
             {

diff --git a/...osition.Hosting/src/System/Composition/Hosting/Providers/Metadata/MetadataViewProvider.cs b/...osition.Hosting/src/System/Composition/Hosting/Providers/Metadata/MetadataViewProvider.cs
@@ -13,7 +13,7 @@ namespace System.Composition.Hosting.Providers.Metadata
 {
     internal static class MetadataViewProvider
     {
-        private static readonly MethodInfo s_getMetadataValueMethod = typeof(MetadataViewProvider).GetTypeInfo().GetDeclaredMethod("GetMetadataValue");
+        private static readonly MethodInfo s_getMetadataValueMethod = typeof(MetadataViewProvider).GetTypeInfo().GetDeclaredMethod(nameof(GetMetadataValue));
 
         // While not called through the composition pipeline, we use the dependency mechanism to surface errors
         // with appropriate context information.