Hardcode the AssemblyName attribute in the .csproj to "Stateless". #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the output .dll is always named "Stateless.dll" instead of "stateless.dll", which can occur due to quirks in the build environment and the way the build system is called. This, in turn, ensures that the output dll name aligns with the AssemblyTitle attribute, ensuring that build systems consuming the library are not confused.
This was referenced Aug 24, 2022
Closed
|
@ffMathy Could I please get a workflow check on this one too? |
|
Yup! There you go! 😊 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the output .dll is always named "Stateless.dll"
instead of "stateless.dll", which can occur due to quirks in the build
environment and the way the build system is called.
This, in turn, ensures that the output dll name aligns with the
AssemblyTitle attribute, ensuring that build systems consuming the
library are not confused.
This is a single commit version of the #470 PR with a more descriptive commit message. It also does not alter the version number. Should fix #449