Bugfix: execute OnEntryFromAsync actions from FireAsync #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed resolution for issue #531.
It seems we missed a mistake in #511 in class
AsyncFrom<TTriggerType>such that a call to the async methodExecuteAsyncwould invoke the synchronousExecute, which intentionally throws anInvalidOperationException.Additionally, the implementation of
AsyncFrom<TTriggerType>.ExecuteAsync(Transition, object[])does not return the task queued to execute the entry action, and instead returnsTask.CompletedTask, making it impossible for the caller toawaitcompletion of the entry action.This PR changes
ExecuteAsyncso that it invokes the async action and returns the queued task.