fix #1031 handle NoWarn+TreatWarningsAsErrors well for F# compilation

dotnet-websharper · Oct 24, 2018 · 4f8bd4d · 4f8bd4d
1 parent d960785
commit 4f8bd4d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/compiler/WebSharper.Compiler.FSharp/Main.fs b/src/compiler/WebSharper.Compiler.FSharp/Main.fs
@@ -76,7 +76,7 @@ type WebSharperFSharpCompiler(logger, ?checker) =
 
         TimedStage "Waiting on merged metadata"
 
-        if checkProjectResults.Errors |> Array.exists (fun e -> e.Severity = FSharpErrorSeverity.Error) then
+        if checkProjectResults.Errors |> Array.exists (fun e -> e.Severity = FSharpErrorSeverity.Error && not (this.WarnSettings.NoWarn.Contains e.ErrorNumber)) then
             if assemblyName = "WebSharper.Main" || config.ProjectType = Some BundleOnly then
                 PrintFSharpErrors this.WarnSettings checkProjectResults.Errors
             None

diff --git a/src/stdlib/WebSharper.MathJS.Extensions/WebSharper.MathJS.Extensions.fsproj b/src/stdlib/WebSharper.MathJS.Extensions/WebSharper.MathJS.Extensions.fsproj
@@ -6,6 +6,8 @@
     <WebSharperProject>Library</WebSharperProject>
     <WebSharperUseNetFxCompiler>True</WebSharperUseNetFxCompiler>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
+    <NoWarn>FS0864</NoWarn>
+    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
   </PropertyGroup>
   <ItemGroup>
     <Compile Include="BigInteger.fs" />