Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offline sitelets (HTML project) link broken #1319

Closed
Jand42 opened this issue Mar 14, 2023 · 2 comments
Closed

Offline sitelets (HTML project) link broken #1319

Jand42 opened this issue Mar 14, 2023 · 2 comments
Labels
6.1.4.277 bug

Comments

@Jand42
Copy link
Member

Jand42 commented Mar 14, 2023

For example in websharper-html template, this should link to about.html instead of just about for navigation to generated file to work correctly.
image
@Jand42 Jand42 added the bug label Mar 14, 2023
@granicz
Copy link
Member

granicz commented Mar 14, 2023

Be careful not to break static apps deployed on a subdirectory prefix. If we don't already, we should be able to set base: .\ or something similar in wsconfig.json - if not, let's add this for offline sitelets.

Jand42 added a commit that referenced this issue Mar 14, 2023
@Jand42
#1319 partial revert of #1260 while keeping error handling
5e35e8e
@Jand42
Copy link
Member Author

Jand42 commented Mar 14, 2023

@granicz at the moment I have reverted to WS5 behavior, which is that all links are relative links. This keeps them work anywhere you have them deployed

@Jand42 Jand42 closed this as completed Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
6.1.4.277 bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jand42 @granicz